-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-31594: Refactored --siteaccess command option to not rely on custom Application class #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
reviewed
Dec 8, 2020
eZ/Bundle/EzPublishCoreBundle/DependencyInjection/Compiler/ConsoleCommandPass.php
Outdated
Show resolved
Hide resolved
eZ/Bundle/EzPublishCoreBundle/DependencyInjection/Compiler/ConsoleCommandPass.php
Show resolved
Hide resolved
eZ/Bundle/EzPublishCoreBundle/Tests/DependencyInjection/Compiler/ConsoleCommandPassTest.php
Outdated
Show resolved
Hide resolved
Thanks @adamwojs. Code fixed according to your review. Tests are now passing, I had to modify test suite to use my fork of meta repository. |
ViniTou
approved these changes
Dec 9, 2020
adamwojs
approved these changes
Dec 9, 2020
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.3
This removes custom
Application
class completely as well asCONSOLE_INIT
event but I assume it can be safely removed because it has been marked@internal
. It injects siteaccess option viaConsoleCommandPass
. Maybe it could be improved and only add the option to commands marked with particular tag but for now I reflected the original behavior.There is complementary PR in meta: ezsystems/ezplatform#627
Checklist:
$ composer fix-cs
).@ezsystems/php-dev-team
).