Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31594: Refactored --siteaccess command option to not rely on custom Application class #145

Merged
merged 8 commits into from
Dec 9, 2020

Conversation

webhdx
Copy link
Contributor

@webhdx webhdx commented Dec 8, 2020

Question Answer
JIRA issue EZP-31594
Type improvement
Target eZ Platform version v3.3
BC breaks no
Doc needed no

This removes custom Application class completely as well as CONSOLE_INIT event but I assume it can be safely removed because it has been marked @internal. It injects siteaccess option via ConsoleCommandPass. Maybe it could be improved and only add the option to commands marked with particular tag but for now I reflected the original behavior.

There is complementary PR in meta: ezsystems/ezplatform#627

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@webhdx webhdx requested review from a team December 8, 2020 11:47
@webhdx webhdx self-assigned this Dec 8, 2020
@adamwojs adamwojs requested a review from a team December 8, 2020 19:42
@webhdx
Copy link
Contributor Author

webhdx commented Dec 9, 2020

Thanks @adamwojs. Code fixed according to your review. Tests are now passing, I had to modify test suite to use my fork of meta repository.

@webhdx webhdx changed the title EZP-31594: Refactored --siteaccess command option to not rely on custom Application class [DO NOT MERGE] EZP-31594: Refactored --siteaccess command option to not rely on custom Application class Dec 9, 2020
@webhdx webhdx changed the title [DO NOT MERGE] EZP-31594: Refactored --siteaccess command option to not rely on custom Application class EZP-31594: Refactored --siteaccess command option to not rely on custom Application class Dec 9, 2020
@webhdx webhdx merged commit 02faeb3 into ezsystems:master Dec 9, 2020
@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@webhdx webhdx deleted the console_init branch December 9, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants