EZP-32250: Exposed PasswordHashService APIs #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ED_PASSWORD_HASHES clarification
alongosz
requested changes
Dec 22, 2020
eZ/Publish/Core/Repository/User/PasswordHashServiceInterface.php
Outdated
Show resolved
Hide resolved
Steveb-p
reviewed
Dec 23, 2020
| interface PasswordHashServiceInterface | ||
| { | ||
| public function getDefaultHashType(): int; | ||
|
|
||
| public function getSupportedHashTypes(): array; |
There was a problem hiding this comment.
Since other methods specifically ask for int.
Suggested change
| public function getSupportedHashTypes(): array; | |
| /** | |
| * @return int[] | |
| */ | |
| public function getSupportedHashTypes(): array; |
Steveb-p
reviewed
Dec 23, 2020
| @@ -24,6 +24,9 @@ | |||
| */ | |||
| abstract class User extends Content implements UserReference | |||
| { | |||
| /** | |||
| * @var int[] List of supported (by default) hash types. | |||
| */ | |||
There was a problem hiding this comment.
Side note: to speed up checks if hash is supported this can be turned into array<int, int>. Then to check support for hash you'd just see if:
isset(User::SUPPORTED_PASSWORD_HASHES[$hashType]);There was a problem hiding this comment.
Premature optimization is the root of all evil
D. Knuth
alongosz
changed the title
alongosz
approved these changes
Dec 23, 2020
Steveb-p
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.3Added methods
getSupportedHashTypes(): arrayisHashTypeSupported(int $hashType): boolto
\eZ\Publish\Core\Repository\User\PasswordHashServiceInterfaceand refactor existing\eZ\Publish\API\Repository\Values\User\User::SUPPORTED_PASSWORD_HASHESusagesThis allows to decorate
PasswordHashServicein 3rd-party bundles and add support for custom password hash types.Checklist:
$ composer fix-cs).@ezsystems/php-dev-team).