Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31795: Introduced proxy objects for content thumbnails #157

Merged
merged 3 commits into from
Jan 13, 2021
Merged

EZP-31795: Introduced proxy objects for content thumbnails #157

merged 3 commits into from
Jan 13, 2021

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Jan 11, 2021 •
edited
Loading

Question Answer
JIRA issue EZP-31795
Type improvement
Target eZ Platform version v3.2
BC breaks no
Doc needed no

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@ViniTou ViniTou changed the base branch from master to 1.2 January 11, 2021 12:20
@micszo micszo self-assigned this Jan 12, 2021
micszo
micszo approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved with image, image asset sanities on Ibexa Commerce 3.2.3-dev and Ibexa Experience v3.2.3 with diff.

@micszo micszo removed their assignment Jan 12, 2021
adamwojs
adamwojs requested changes Jan 12, 2021
View reviewed changes
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 but you need add \eZ\Publish\API\Repository\Values\Content\Thumbnail to \eZ\Bundle\EzPublishCoreBundle\Cache\Warmer\ProxyCacheWarmer::PROXY_CLASSES See ezsystems/ezpublish-kernel#2844 for more details.

@lserwatka
Copy link
Member

@ViniTou we need to address it.

@ViniTou ViniTou requested a review from adamwojs January 13, 2021 07:54
@sonarcloud
Copy link

sonarcloud bot commented Jan 13, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lserwatka lserwatka merged commit 958583c into 1.2 Jan 13, 2021
@lserwatka lserwatka deleted the EZP-31795-proxy-thumbnails branch January 13, 2021 09:24
@lserwatka
Copy link
Member

@ViniTou could you merge it up?

Steveb-p pushed a commit that referenced this pull request Feb 10, 2023
@ViniTou @patrickallaert
[Twig] Fixed missing ibexa_render_content function (#157)
ca997cf 
Typo made in e766878

Co-authored-by: Patrick Allaert <patrickallaert@php.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lserwatka lserwatka lserwatka approved these changes

@adamwojs adamwojs adamwojs approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@Nattfarinn Nattfarinn Nattfarinn approved these changes

@micszo micszo micszo approved these changes

@kaff kaff Awaiting requested review from kaff

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

@webhdx webhdx Awaiting requested review from webhdx

Assignees
No one assigned
Labels
QA approved
Milestone
No milestone
6 participants
@ViniTou @lserwatka @adamwojs @Steveb-p @Nattfarinn @micszo