EZP-32284: Made type parameter optional in InstallPlatformCommand
#159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webhdx
added
Improvement
webhdx
requested review from
lserwatka,
mikadamczyk,
Steveb-p,
micszo and
ViniTou
|
Kudos, SonarCloud Quality Gate passed!
|
lserwatka
approved these changes
Jan 12, 2021
ViniTou
approved these changes
Jan 13, 2021
mikadamczyk
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.3For some reason
ibexa:installcommand always requires to passtypeexplicitly. It becomes a huge issue with number of products we now offer. This PR madestypeargument optional and will useibexa-ossinstaller by default. This is only a part of full solution as for enterprise editions the installer will automatically select relevant installation type based on installed product. That to be provided via separate package.Checklist:
$ composer fix-cs).@ezsystems/php-dev-team).