Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-32281: IndexRequestListener requires redirect #161

Merged
merged 2 commits into from
Jan 20, 2021
Merged

EZP-32281: IndexRequestListener requires redirect #161

merged 2 commits into from
Jan 20, 2021

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Jan 15, 2021 •
edited

Question Answer
JIRA issue EZP-32281
Type bug
Target eZ Platform version v3.1
BC breaks no
Doc needed no

IndexRequestListener originally had needsForward set to true which later on resulted in needsCaseRedirect in UrlAliasRouter returning false as both paths were the same which finally resulted in redirect not being fired. That shouldn't be the case and the redirect should occur at an earlier stage without the unnecessary forward.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@barw4 barw4 added Bug Something isn't working Ready for review labels Jan 15, 2021
@barw4 barw4 self-assigned this Jan 15, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jan 15, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@barw4 barw4 requested review from a team and removed request for adamwojs, alongosz and ViniTou January 15, 2021 18:19
@bogusez bogusez assigned bogusez and unassigned barw4 Jan 19, 2021
@bogusez bogusez removed their assignment Jan 20, 2021
@lserwatka lserwatka merged commit 13bf926 into 1.1 Jan 20, 2021
@lserwatka lserwatka deleted the ezp-32281-fix-index-request-listener branch January 20, 2021 12:48
@lserwatka
Copy link
Member

Could you merge it up?

@barw4
Copy link
Member Author

barw4 commented Jan 20, 2021

Merged into:
master: dd0edc9
1.2: d59089d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@webhdx webhdx webhdx approved these changes

@ViniTou ViniTou ViniTou approved these changes

@bogusez bogusez bogusez approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working QA approved
Milestone
No milestone
6 participants
@barw4 @lserwatka @Steveb-p @webhdx @ViniTou @bogusez