Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-32384: Fixed time depended tests #169

Merged
merged 4 commits into from
Mar 10, 2021
Merged

EZP-32384: Fixed time depended tests #169

merged 4 commits into from
Mar 10, 2021

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Mar 8, 2021 •
edited

Question Answer
JIRA issue EZP-32384
Type improvement
Target eZ Platform version v3.2
BC breaks no
Doc needed no

symfony/symfony#40043

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@ViniTou ViniTou changed the base branch from master to 1.2 March 8, 2021 15:17
@ViniTou ViniTou requested review from a team, alongosz and Steveb-p March 9, 2021 12:28
@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ViniTou ViniTou requested a review from a team March 10, 2021 07:49
@lserwatka lserwatka merged commit 04651cc into 1.2 Mar 10, 2021
@lserwatka lserwatka deleted the ezp-32384-tests branch March 10, 2021 08:10
@lserwatka
Copy link
Member

Could you merge it up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@alongosz alongosz alongosz approved these changes

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@ViniTou @lserwatka @adamwojs @alongosz