Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-143: Fixed merge-up of reindex command changes #178

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Apr 12, 2021

Question Answer
JIRA issue IBX-143
Type bug
Target Ibexa version v3.3+
BC breaks no
Tests pass yes, failure is unrelated

This PR aligns a merge up of ezsystems/ezpublish-kernel#3094 changes with master.
All commands are defined in eZ/Bundle/EzPublishCoreBundle/Resources/config/commands.yml, so the old definition was removed from eZ/Bundle/EzPublishCoreBundle/Resources/config/services.yml.

Moreover the command can't be lazy as it seems not compatible with BackwardCompatibleCommand feature (making both ibexa:reindex and ezplatform:reindex available, with the latter one triggering deprecation warning).

Checklist:

@alongosz alongosz added Bug Something isn't working Ready for review labels Apr 12, 2021
@alongosz alongosz requested review from adamwojs, webhdx and a team April 12, 2021 16:04
@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moreover the command can't be lazy as it seems not compatible with BackwardCompatibleCommand feature (making both ibexa:reindex and ezplatform:reindex available, with the latter one triggering deprecation warning).

It's have nothing to do with BackwardCompatibleCommand. This interface is only responsible for defining which command aliases are considered as deprecated.

According to Symfony documentation (ref. https://symfony.com/doc/current/console/commands_as_services.html#lazy-loading)

If the command defines aliases (using the getAliases() method) you must add one console.command tag per alias.

@alongosz alongosz merged commit ef520af into master Apr 13, 2021
@alongosz alongosz deleted the ibx-134-merge-into-master branch April 13, 2021 11:33
@alongosz
Copy link
Member Author

Merged to unblock crashing dev-master.

Steveb-p pushed a commit that referenced this pull request Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Ready for review
5 participants