IBX-340: Allowed URL Gateway queries to not perform count operations

[Steveb-p]

Question	Answer
JIRA issue	IBX-340
Type	improvement
Target eZ Platform version	v3.3
BC breaks	no
Doc needed	no

Prevent multiple database count queries when paginating URL lists.

Without the patch:

With the patch:

Checklist:

• Provided PR description.
• Tested the solution manually.
• Provided automated test coverage.
• Checked that target branch is set correctly (master for features, the oldest supported for bugs).
• Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
• Asked for a review (ping @ezsystems/php-dev-team).

[lserwatka]

@Steveb-p we need a JIRA ticket for this PR, so our automatic changelog generator can hook it.

[Steveb-p]

@lserwatka a proper Jira ticket has been added: IBX-340

[adamwojs]

+1 but please create/update integration test. It's PAPI change

[Steveb-p]

@adamwojs tests have been added.

Unfortunately tests for URL Gateway itself were missing, so I had to add them - and they show that some of the load* family functions return result sets, even though they should always return only 1 row. I didn't change that as that would technically be a behavior change.

I added the additional argument into Handler test case - it should cause the test to fail in cases where it isn't passed, so I think that's enough for unit tests for this one?

[Steveb-p]

I've added some additional changes that I wanted to make a different PR with, but considering they are related to the changes here I'm including them now.

1. eZ\Publish\Core\FieldType\Url\UrlStorage\Gateway\DoctrineStorage now shares constants with eZ\Publish\Core\Persistence\Legacy\URL\Gateway\DoctrineDatabase (for discoverability and to prevent making changes to one but not the other).
2. Tests do not make use of constants (to detect changes to those)
3. I've added coverage annotation to test cases I've touched. I'd like to advocate usage of class-level coverage annotation instead of method based one, as they are not endorsed by phpunit. They are also not properly detected by phpstorm afaik; for example multiple DoctrineGateway are displayed when test cases are requested, even though they come from different classes (see ctrl+shift+T shortcut on implementation class).

I'm unsure what to do with duplicated code detected by sonar cloud - it seems to come from a fixture file, which to be honest I don't see duplicated anywhere in terms of data contained 😕

[adamwojs]

+1 but please create/update integration test. It's PAPI change

@Steveb-p I meant \eZ\Publish\API\Repository\Tests\URLServiceTest here 😉

[Steveb-p]

@adamwojs URLService tests have been updated.

[Steveb-p]

Sonar cloud analysis:

1. Duplication detects same code in https://github.com/ezsystems/ezplatform-kernel/blob/ab7f16fca538dd0e0e157bfb0151d023da1931fd/eZ/Publish/Core/Persistence/Legacy/Tests/Content/UrlAlias/_fixtures/publish_multilingual.php, which is clearly an entirely different file 😖
2. Security hotspots are related to used http protocol in links in tests. I could "upgrade" them to https, but that would be a lot of unrelated changed code updated to https in f8f6bd2.

[sonarcloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
18 Code Smells

No Coverage information
11.9% Duplication

[tomaszszopinski]

QA approved on Ibexa Exp 3.2.7-dev.

[Steveb-p]

Merged up in

• 1.3 - 68bccd7
• master - 5a5d8dd