Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-300 changed search field data to using timezone for timestamp #185

Merged
merged 1 commit into from
May 21, 2021
Merged

IBX-300 changed search field data to using timezone for timestamp #185

merged 1 commit into from
May 21, 2021

Conversation

mateuszdebinski
Copy link
Contributor

@mateuszdebinski mateuszdebinski commented May 19, 2021 •
edited

Question Answer
JIRA issue IBX-300
Type bug
Target eZ Platform version v3.2, v3.3
BC breaks no
Doc needed no

After merged up to the master, appeared a problem with the test SOLR, so I changed the searchField class to using timezone like another place with a date field

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@sonarcloud
Copy link

sonarcloud bot commented May 19, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mateuszdebinski mateuszdebinski marked this pull request as ready for review May 19, 2021 13:51
@mateuszdebinski mateuszdebinski added Bug Something isn't working Ready for review labels May 19, 2021
alongosz
alongosz approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 since the existing test coverage exposed the issue AFAIK

@bogusez bogusez self-assigned this May 20, 2021
@lserwatka lserwatka merged commit 34530d8 into 1.2 May 21, 2021
@Steveb-p Steveb-p mentioned this pull request Jul 21, 2021
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@alongosz alongosz alongosz approved these changes

@bogusez bogusez bogusez approved these changes

@adamwojs adamwojs Awaiting requested review from adamwojs

Assignees

@bogusez bogusez

Labels
Bug Something isn't working QA approved
Milestone
No milestone
5 participants
@mateuszdebinski @Steveb-p @alongosz @bogusez @lserwatka