Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-527: Fixed phpdoc return type mismatch in RepositoryParamConverter #200

Merged
merged 1 commit into from
Jun 18, 2021
Merged

IBX-527: Fixed phpdoc return type mismatch in RepositoryParamConverter #200

merged 1 commit into from
Jun 18, 2021

Conversation

Steveb-p
Copy link
Contributor

Question Answer
JIRA issue IBX-527 (depends on this for static analysis)
Type bug
Target eZ Platform version v3.3
BC breaks no, phpdoc only
Doc needed no

eZ\Bundle\EzPublishCoreBundle\Converter\ContentParamConverter & eZ\Bundle\EzPublishCoreBundle\Converter\LocationParamConverter (descendants) both return ValueObjects, not strings.

New CustomerGroupParamConverter will also return a ValueObject.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@Steveb-p Steveb-p requested a review from a team June 18, 2021 11:40
@sonarcloud
Copy link

sonarcloud bot commented Jun 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adamwojs adamwojs merged commit e624610 into 1.2 Jun 18, 2021
@adamwojs adamwojs deleted the fix-phpdoc branch June 18, 2021 12:30
@adamwojs
Copy link
Member

Could you please merge up changes @Steveb-p?

@Steveb-p
Copy link
Contributor Author

Merged up in 1be1a87 (1.2) and 2f04f58 (master)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lserwatka lserwatka lserwatka approved these changes

@adamwojs adamwojs adamwojs approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@alongosz alongosz alongosz approved these changes

@ciastektk ciastektk ciastektk approved these changes

@webhdx webhdx webhdx approved these changes

@ViniTou ViniTou ViniTou approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
8 participants
@Steveb-p @adamwojs @lserwatka @mikadamczyk @alongosz @ciastektk @webhdx @ViniTou