Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-665: Bumped Symfony dependency to 5.3 #206

Merged
merged 4 commits into from
Jul 6, 2021
Merged

IBX-665: Bumped Symfony dependency to 5.3 #206

merged 4 commits into from
Jul 6, 2021

Conversation

webhdx
Copy link
Contributor

@webhdx webhdx commented Jun 29, 2021

Question Answer
JIRA issue IBX-665
Type improvement
Target eZ Platform version v3.3
BC breaks yes
Doc needed no

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@webhdx webhdx added Improvement Changes not fixing or changing behavior Ready for review labels Jun 29, 2021
@webhdx webhdx requested review from a team June 29, 2021 10:06
@webhdx webhdx self-assigned this Jun 29, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lserwatka lserwatka merged commit fd9c880 into 1.3 Jul 6, 2021
@lserwatka lserwatka deleted the symfony53 branch July 6, 2021 10:06
@Steveb-p
Copy link
Contributor

Steveb-p commented Jul 6, 2021

Hard requirement of ezpublish.session_set_dynamic_name_listener for session.storage.factory service breaks integration tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@mnocon mnocon mnocon approved these changes

Assignees

@webhdx webhdx

Labels
Improvement Changes not fixing or changing behavior Ready for review
Milestone
No milestone
5 participants
@webhdx @Steveb-p @adamwojs @mnocon @lserwatka