Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-688: SettingService::buildSettingDomainObject deserialize hashes as stdClass #208

Merged
merged 1 commit into from
Jul 2, 2021
Merged

IBX-688: SettingService::buildSettingDomainObject deserialize hashes as stdClass #208

merged 1 commit into from
Jul 2, 2021

Conversation

adamwojs
Copy link
Member

Question Answer
JIRA issue IBX-688
Type bug
Target eZ Platform version v3.3
BC breaks yes
Doc needed ?

Setting value representation should not be changed when loading it from persistence.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@adamwojs adamwojs added the Bug Something isn't working label Jun 30, 2021
@adamwojs adamwojs self-assigned this Jun 30, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adamwojs adamwojs requested a review from a team June 30, 2021 10:12
@adamwojs adamwojs requested a review from a team June 30, 2021 10:42
@adamwojs adamwojs merged commit 6f19fb8 into 1.3 Jul 2, 2021
@adamwojs adamwojs deleted the ibx_688 branch July 2, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lserwatka lserwatka lserwatka approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

Assignees

@adamwojs adamwojs

Labels
Bug Something isn't working
Milestone
No milestone
3 participants
@adamwojs @lserwatka @Steveb-p