Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-1195: Added default value for DATABASE_URL for IbexaTestKernel #238

Merged
merged 1 commit into from
Oct 6, 2021
Merged

IBX-1195: Added default value for DATABASE_URL for IbexaTestKernel #238

merged 1 commit into from
Oct 6, 2021

Conversation

Steveb-p
Copy link
Contributor

@Steveb-p Steveb-p commented Oct 6, 2021

Question Answer
JIRA issue IBX-1195
Type improvement
Target Ibexa version v4.0
BC breaks no

Default to in-memory SQLite database for integration tests.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@Steveb-p Steveb-p changed the base branch from master to 1.3 October 6, 2021 09:08
@Steveb-p Steveb-p force-pushed the test-kernel-database-default branch from c6d350a to 74c1068 Compare October 6, 2021 09:27
@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adamwojs adamwojs merged commit d1947f2 into 1.3 Oct 6, 2021
@adamwojs adamwojs deleted the test-kernel-database-default branch October 6, 2021 11:22
@adamwojs
Copy link
Member

adamwojs commented Oct 6, 2021

Could you please merge up changes @Steveb-p ?

@Steveb-p
Copy link
Contributor Author

Steveb-p commented Oct 6, 2021

Merged into master in 7e7130a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lserwatka lserwatka lserwatka approved these changes

@damianz5 damianz5 damianz5 approved these changes

@alongosz alongosz alongosz approved these changes

@ciastektk ciastektk ciastektk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
6 participants
@Steveb-p @adamwojs @lserwatka @damianz5 @alongosz @ciastektk