IBX-1258: Fixed multiple FixtureImporter::import() calls not resetting sequences

[Steveb-p]

Question	Answer
JIRA issue	IBX-1258
Type	improvement
Target Ibexa version	v3.3
BC breaks	no

This changes the internal cache for FixtureImporter, and how it is regenerated when new fixtures are imported.

Previously, calling FixtureImporter::import() multiple times (with different Fixtures) was possible, but sequence keys for Fixtures after the first one were not regenerated properly. This results in issues when different tests receive different fixtures, usually concluding in primary key constraint validations.

Checklist:

• Provided PR description.
• Tested the solution manually.
• Provided automated test coverage.
• Checked that target branch is set correctly (master for features, the oldest supported for bugs).
• Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
• Asked for a review (ping @ezsystems/engineering-team).

[alongosz]

Extract $this->connection->getDatabasePlatform() to the variable set outside of foreach scope please

[Steveb-p]

Fixed in bfbb062.

Additionally variable name containing tables that were not previously covered by sequence reset value generation is renamed from $diff to $unvisitedTables.

[Steveb-p]

@alongosz codebase has been changed to include the fact that some tables might not have an autoincrement column - which in previous code would cause them to be constantly queried.

This causes the FixtureImporter::$resetSequenceStatements property to change it's declaration to array<string, string|null>, where null value indicates a table without autoincrement.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication