Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-2634: Added argument to functions to ignore ownership #321

Closed
wants to merge 2 commits into from

Conversation

mateuszdebinski
Copy link
Contributor

@mateuszdebinski mateuszdebinski commented Jul 7, 2022

Question Answer
JIRA issue IBX-2634
Type bug/improvement
Target Ibexa version v3.3
BC breaks no

In order not to change the interface and not to cause BC, only the functions have been changed so that you can pass the argument to ignore the owner - the mechanism itself already existed in our product

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIR any change needs to be reflected on an API interface, because we use ProxyManager which won't see them otherwise. But... @adamwojs could you validate that statement? ;)

Question: what is the use case?

@mateuszdebinski
Copy link
Contributor Author

@alongosz

If I remember correctly, the API interface change won't go through because of BC.

In migration, we allow setting creatorId or modifierId, if a user does not have the appropriate permissions then we throw an exception. However, I probably went a bit too far, because as I read the ticket now, the client would like that if the user does not exist or does not have permission to create/edit, should be used, default user in migration (admin) or from --user-context option

Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels to me that this should be fixed in ibexa/migrations.
POV ping @Steveb-p

@mateuszdebinski
Copy link
Contributor Author

I close this PR as we can do it in the migration bundle itself

@alongosz alongosz deleted the IBX-2634-add-ignoreOwner-argument branch July 15, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants