IBX-3451: [Behat] Removed depending on APP_ENV when loading Context services #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnocon
force-pushed
the
fix-context-loading
branch
from
a7411fe
to
c0492c4
Compare
mnocon
changed the title
mnocon
force-pushed
the
fix-context-loading
branch
from
c0492c4
to
387dd5e
Compare
mnocon
force-pushed
the
fix-context-loading
branch
from
387dd5e
to
06f4d5b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
mnocon
requested review from
bogusez,
katarzynazawada,
micszo,
tomaszszopinski and
a team
konradoboza
approved these changes
Aug 11, 2022
adamwojs
approved these changes
Aug 11, 2022
micszo
approved these changes
Aug 11, 2022
alongosz
approved these changes
Aug 12, 2022
| @@ -91,8 +91,7 @@ public function load(array $configs, ContainerBuilder $container) | |||
|
|
|||
| $configuration = $this->getConfiguration($configs, $container); | |||
|
|
|||
| $environment = $container->getParameter('kernel.environment'); | |||
| if (in_array($environment, ['behat', 'test'])) { | |||
| if ($this->shouldLoadTestServices($container)) { | |||
There was a problem hiding this comment.
Now that I see it, I think it should be a separate bundle, not a part of Core ;)
bogusez
approved these changes
Aug 16, 2022
bogusez
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.ibexa.co/browse/IBX-3451 (Customer request)
Backport of a change introduced in ibexa/core#92 (ibexa/core@073a5cc) to v3.3 because of the ticket mentioned above.
Relying on a parameter (prepended by ibexa/behat package) is better than relying on hardcoded Symfony env (and does not require adding optional dependencies to bypass it).
I've also added small tests, because it's a Customer Request.
Related PR: ezsystems/ezplatform-content-forms#62