Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-360 - Added \d+ requirement on contentId parameter for ez_content_download_field_id route #325

Merged
merged 2 commits into from Aug 5, 2022
Merged

IBX-360 - Added \d+ requirement on contentId parameter for ez_content_download_field_id route #325

merged 2 commits into from Aug 5, 2022

Conversation

mateuszbieniek
Copy link
Contributor

Question Answer
JIRA issue IBX-360
Type bug
Target Ibexa version v3.3
BC breaks no

This PR adds a requirement on contentId parameter for route ez_content_download_field_id so 404 will be returned instead of 500 whenever someone uses the route with a nondigit contentId.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@mateuszbieniek mateuszbieniek added Bug Something isn't working Ready for review labels Aug 2, 2022
@mateuszbieniek mateuszbieniek requested a review from a team August 2, 2022 10:12
@mateuszbieniek mateuszbieniek self-assigned this Aug 2, 2022
adamwojs
adamwojs approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please do the same for fieldId parameter ?

@sonarcloud
Copy link

sonarcloud bot commented Aug 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.6% 0.6% Duplication

tomaszszopinski
tomaszszopinski approved these changes Aug 5, 2022
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 3.3 commerce.

@adamwojs adamwojs merged commit d463500 into ezsystems:1.3 Aug 5, 2022
@adamwojs
Copy link
Member

adamwojs commented Aug 5, 2022

@mateuszbieniek Could you please merge up changes?

@mateuszbieniek mateuszbieniek deleted the ibx-360 branch August 5, 2022 11:41
@mateuszbieniek
Copy link
Contributor Author

mateuszbieniek commented Aug 5, 2022 •
edited

@adamwojs Merge up PR:
ibexa/core#131

alongosz added a commit to ibexa/core that referenced this pull request Aug 5, 2022
@alongosz
Merged branch '1.3' of ezsystems/ezplatform-kernel into 4.1 (#131)
ff79358 
Merge up of: ezsystems/ezplatform-kernel#325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@konradoboza konradoboza konradoboza approved these changes

@mateuszdebinski mateuszdebinski mateuszdebinski approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

Assignees

@adamwojs adamwojs

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@alongosz alongosz

@ciastektk ciastektk

@mateuszbieniek mateuszbieniek

Labels
Bug Something isn't working QA approved
Milestone
No milestone
9 participants
@mateuszbieniek @adamwojs @konradoboza @mateuszdebinski @tomaszszopinski @mikadamczyk @Steveb-p @alongosz @ciastektk