Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-3167: Fixed performance issue in URL Alias cache invalidation #326

Merged
merged 4 commits into from Aug 17, 2022

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Aug 2, 2022

Question Answer
JIRA issue IBX-3167
Type improvement
Target Ibexa version v3.3+
BC breaks no[1]

This PR reverts #308 and applies more optimal way of cache invalidation of archived entry with overlapping URL for a new Location. Looks like these entries share one tag in common: identity key (URLAlias::$id) in the form of <url_alias_parent_id>-<name_md5_hash>. This identity key has been returned from \eZ\Publish\SPI\Persistence\Content\UrlAlias\Handler::publishUrlAliasForLocation to be utilized in cache layer.

[1] The breaking interface change applies to SPI\Persistence* interface which is excluded from BC promise.

TODO

  • See if CI passes
  • Refactor some parts of related code (future PRs as it does not impact performance in the reported area)
  • See if there's visible effect for Reporter's profile. //

QA

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review

@alongosz alongosz added Improvement Changes not fixing or changing behavior Work in progress labels Aug 2, 2022
@alongosz alongosz marked this pull request as ready for review August 4, 2022 13:45
@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on Ibexa Commerce v3.3.24.

@micszo micszo removed their assignment Aug 17, 2022
@adamwojs adamwojs merged commit 01d1b13 into 1.3 Aug 17, 2022
@adamwojs adamwojs deleted the ibx-3167-publishing-performance branch August 17, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Changes not fixing or changing behavior QA approved
8 participants