Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-3823: Fixed appending limitations, when there are no initial values #335

Merged
merged 1 commit into from Sep 22, 2022

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Sep 14, 2022

Question Answer
JIRA issue IBX-3823
Type bug
Target Ibexa version v3.3
BC breaks no

As when there were no limitations assigned to policy, $previousPolicyMap[$module][$function] is null, and array_merge_recursive was throwing type error.

This could be reproduced with new PolicyProviderInterface for example with:

    public function addPolicies(ConfigBuilderInterface $configBuilder)
    {
        $configBuilder->addConfig([
            'setup' => [
                'administrate' => ['SiteAccess'],
            ],
        ]);
    }

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ViniTou ViniTou requested a review from a team September 14, 2022 10:56
@Nattfarinn Nattfarinn requested a review from a team September 16, 2022 08:34
@konradoboza konradoboza requested a review from a team September 16, 2022 08:43
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on Ibexa Commerce 3.3.27-dev.

@micszo micszo removed their assignment Sep 22, 2022
@ViniTou ViniTou merged commit 3524a95 into 1.3 Sep 22, 2022
@ViniTou ViniTou deleted the ibx-3823-policy-provider-fix branch September 22, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
9 participants