IBX-4877: Allow Location-based Content preview #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barw4
added
Improvement
ViniTou
approved these changes
Feb 1, 2023
eZ/Publish/Core/MVC/Symfony/Controller/Content/PreviewController.php
Outdated
Show resolved
Hide resolved
| @@ -7,7 +7,9 @@ | |||
| {% endif %} | |||
| <title>{{ title|default( 'Home' ) }}</title> | |||
| <meta name="generator" content="Ibexa DXP"/> | |||
| {% if content is defined and content.contentInfo.mainLocationId %} | |||
| {% if content is defined and location is defined and location is not null and location.id is not null %} | |||
There was a problem hiding this comment.
is there really a possibility, that location.id is null?
There was a problem hiding this comment.
Yes, that can be a case, hence 24a5b01
There was a problem hiding this comment.
@alongosz @ViniTou It is null by default, for example when one is creating a new LP anywhere and kernel gives us a preview, this is a standard behavior even without this PR:
This is a direct result of https://github.com/ezsystems/ezplatform-kernel/blob/1.3/eZ/Publish/Core/Helper/PreviewLocationProvider.php#L101-L109
ciastektk
approved these changes
Feb 1, 2023
Nattfarinn
approved these changes
Feb 1, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
konradoboza
approved these changes
Feb 2, 2023
webhdx
approved these changes
Feb 2, 2023
alongosz
approved these changes
Feb 6, 2023
Steveb-p
approved these changes
Feb 6, 2023
This was referenced Feb 6, 2023
bogusez
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.3As the title suggests. Using only main Location for preview would prevent certain users without access to main Location but with access to secondary Location from previewing such content.
Related PRs:
Checklist:
$ composer fix-cs).@ezsystems/engineering-team).