Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-4477: Added LocationService::getSubtreeSize method #360

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Jan 31, 2023

Question Answer
JIRA issue IBX-4477
Required by ezsystems/ezplatform-admin-ui#2085
Type bug
Target Ibexa version v3.3
BC breaks no
Regression build ibexa/commerce#214

Added dedicated method to retrieve subtree size

interface LocationService {
    # ...

    /**
     * Return the subtree size of a given location.
     *
     * Warning! This method is not permission aware by design.
     */
    public function getSubtreeSize(Location $location): int;

    # ...
}

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@sonarcloud
Copy link

sonarcloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alongosz alongosz requested a review from a team February 9, 2023 13:22
@konradoboza konradoboza requested a review from a team February 9, 2023 13:32
@micszo micszo self-assigned this Feb 10, 2023
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With customer's DB locally observed very significant performance improvement. 💪🏻

QA Approved on Ibexa Experience 3.3.31-dev.

Side, also noticed that now copy subtree (except -1 / no limit) is disabled for a one element tree. Before it was possible to use copy subtree as copy.

@micszo micszo removed their assignment Feb 13, 2023
@alongosz alongosz merged commit b787ccb into 1.3 Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working QA approved
9 participants