IBX-829 [CI] Moved CS and PHPUnit jobs to Github Actions #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrbisaga
changed the title
Steveb-p
reviewed
Sep 16, 2021
.github/workflows/ci.yaml
Outdated
|
|
||
| - name: Run test suite | ||
| run: composer run-script --timeout=600 test | ||
|
|
There was a problem hiding this comment.
(whitespace leftover, which makes git complain about missing newline)
Suggested change
What editor are you using? VSCode?
There was a problem hiding this comment.
Thanks. Yes, VSCode
There was a problem hiding this comment.
We could add .editorconfig files to each repository to prevent VSCode leaving trailing spaces. Or you could configure it to do it on it's own. I'm pretty sure there's an option for that.
mnocon
approved these changes
Sep 21, 2021
.github/workflows/ci.yaml
Outdated
| - '7.3' | ||
| - '7.4' | ||
| composer_options: [ "" ] | ||
| experimental: [false] |
|
Kudos, SonarCloud Quality Gate passed!
|
Steveb-p
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusting CI test to GitHub Actions instead of Travis
https://issues.ibexa.co/browse/IBX-829