Make FieldDefinitionIdentifier matcher actually test the field identifier #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunogier
changed the title
bdunogier
force-pushed
the
ezp31677-fix_field_definition_identifier_matcher
branch
from
df2fb41
to
8422492
Compare
adamwojs
approved these changes
Jun 10, 2020
Nope, EZP-31568 is still to be scheduled. |
|
Okay thank you. Not critical, but it would still be a very nice DX improvement, especially with that field... Or I can reintroduce that hack that modifies the view config to replace it with the service's id 😈 |
alongosz
requested changes
Jun 10, 2020
bdunogier
force-pushed
the
ezp31677-fix_field_definition_identifier_matcher
branch
from
868558d
to
6bd0c8f
Compare
|
Rebased, should be ready to merge. |
bdunogier
force-pushed
the
ezp31677-fix_field_definition_identifier_matcher
branch
from
445bfdb
to
2f8848b
Compare
adamwojs
approved these changes
Jun 18, 2020
|
@bdunogier you can merge it up. We will do QA as part of RC1 |
|
Yes, I'm on it. |
|
Merged to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2.5,v3.0,v3.1Changes
FieldDefinitionIdentifiermatcher to actually test that the matched view is for the configured field definition identifier. To make it possible, the view must include afieldIdentifierparameter set to the field being rendered.Checklist:
$ composer fix-cs).