Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render based on the current location (GraphQL v3) #53

Closed
wants to merge 11 commits into from
Closed

Render based on the current location (GraphQL v3) #53

wants to merge 11 commits into from

Conversation

bdunogier
Copy link
Member

No description provided.

Bertrand Dunogier added 11 commits December 16, 2020 11:17
EZP-31659: Added QueryFieldLocationService for getting results for a …
f2b67c9 
…location
EZP-31659: use location methods from QueryResultsInjector
c6afe3a
Added PaginationSupport
7b0ec9a
Use objects as view controller arguments
f36374b
EZP-31659: Implemented getting query field results for a specific loc…
a082528 
…ation with REST

An extra 'location' query parameter can be provided with a location href. If provided, that particular location will be used instead of the main one.
Signature fix
d7f318f
Made the GraphQL resolver compatible with GraphQL v3 and the item API
2777f0f
fixup! Use objects as view controller arguments
ed5b0b7
fixup! EZP-31659: Implemented getting query field results for a speci…
b109ea6 
…fic location with REST
fixup! EZP-31659: Added QueryFieldLocationService for getting results…
475abfe 
… for a location
fixup! EZP-31659: Added QueryFieldLocationService for getting results…
8332f33 
… for a location
@dabrt
Copy link

dabrt commented Feb 1, 2021

Bon jour!
Does this PR require documentation?
Does it relate to EZP-31659 only, or there are other dependencies?
What product versions does it affect (will be merged to)?

@bdunogier
Copy link
Member Author

bdunogier commented Feb 1, 2021 •
edited

Does it relate to EZP-31659 only

Yes, besides the small change to admin-ui where we pass the location when rendering fields (so that we know what location is the current one).

It also depends on the future 3.0 version of the GraphQL package, that introduces advanced location & siteaccess handling.

Does this PR require documentation?

Yes, it does. I will complete the pull-request, sorry about that :)

What product versions does it affect (will be merged to)?

The goal is to merge it to the next major version of the package (3.0), and tag it as a beta version that can be installed on top of the LTS version.

@dabrt
Copy link

dabrt commented Feb 1, 2021

Yes, it does. I will complete the pull-request, sorry about that :)

Merci!

@DominikaK DominikaK added the Doc needed The changes require some documentation label Mar 2, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Nattfarinn Nattfarinn deleted the branch master November 19, 2021 15:20
@Nattfarinn Nattfarinn closed this Nov 19, 2021
@bdunogier
Copy link
Member Author

I need to go a bit deeper into it, but this is still valid, as far as I can tell (it is a follow-up to the "better location handling" story).

@DominikaK DominikaK removed the Doc needed The changes require some documentation label Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@bdunogier @dabrt @Nattfarinn @DominikaK