Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CS] Fixed CS #50

Merged
merged 1 commit into from May 29, 2020
Merged

[CS] Fixed CS #50

merged 1 commit into from May 29, 2020

Conversation

mnocon
Copy link
Member

@mnocon mnocon commented May 28, 2020 •
edited

Question Answer
JIRA issue https://jira.ez.no/browse/EZP-31578
Type improvement
Target version 1.0, master
BC breaks no
Tests pass yes
Doc needed no

Build are currently failing on Travis: https://travis-ci.org/github/ezsystems/ezplatform-rest/branches

And that's because of incorrect codestyle. This PR fixes that.

TODO:

  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@mnocon mnocon requested review from ViniTou, adamwojs and a team May 28, 2020 08:27
micszo
micszo approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adamwojs adamwojs merged commit 30b42ca into 1.0 May 29, 2020
@adamwojs adamwojs deleted the fix-cs branch May 29, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@micszo micszo micszo approved these changes

@bogusez bogusez bogusez approved these changes

@ViniTou ViniTou Awaiting requested review from ViniTou

Assignees
No one assigned
Labels
Ready for review
Milestone
No milestone
4 participants
@mnocon @adamwojs @micszo @bogusez