Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-32340: Fixed FieldTypeProcessorPass::{FIELD_TYPE_PROCESSOR_SERVICE_TAG,DEPRECATED_FIELD_TYPE_PROCESSOR_SERVICE_TAG} access modifier #64

Merged
merged 1 commit into from
Feb 19, 2021
Merged

EZP-32340: Fixed FieldTypeProcessorPass::{FIELD_TYPE_PROCESSOR_SERVICE_TAG,DEPRECATED_FIELD_TYPE_PROCESSOR_SERVICE_TAG} access modifier #64

merged 1 commit into from
Feb 19, 2021

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Feb 19, 2021 •
edited
Loading

Question Answer
JIRA issue EZP-32340
Type improvement
Target version e.g.: eZ Platform v3.0.0
BC breaks no
Tests pass yes
Doc needed no

Applied #63 (comment).

TODO:

  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@adamwojs
EZP-32340: Fixed FieldTypeProcessorPass::{FIELD_TYPE_PROCESSOR_SERVIC…
a262355 
…E_TAG,DEPRECATED_FIELD_TYPE_PROCESSOR_SERVICE_TAG} access modifier
@adamwojs adamwojs self-assigned this Feb 19, 2021
@adamwojs adamwojs mentioned this pull request Feb 19, 2021
Merged
3 tasks
@adamwojs adamwojs merged commit 20dd6c5 into 1.2 Feb 19, 2021
@adamwojs adamwojs deleted the ezp_32340_followup branch February 19, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

Assignees

@adamwojs adamwojs

Labels
Improvement
Milestone
No milestone
2 participants
@adamwojs @Steveb-p