Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Aligned SetupFactory to include PermissionService #139

Merged

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Apr 14, 2020

Question Answer
JIRA issue Follow up for EZP-30465 introduced via ezsystems/ezplatform-kernel#44
Bug/Improvement yes
Target version Test setup of eZ Platform v3.0.x
BC breaks no
Tests pass yes
Doc needed yes

This is a follow-up aligning integration tests SetupFactory with changes from ezsystems/ezplatform-kernel#44. Config for autowire.yml was not loaded.

Please note that this not very DRY solution needs to be changed, but here it's out of scope. The scope here is to unblock failing CI: https://travis-ci.org/github/ezsystems/ezplatform-richtext/builds/674730281.

TODO:

  • Fix a bug.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@alongosz alongosz added the Bug Something isn't working label Apr 14, 2020
Copy link
Member

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@alongosz alongosz merged commit c95d347 into ezsystems:master Apr 14, 2020
@alongosz alongosz deleted the align-tests-with-permission-service branch April 14, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Ready for review
2 participants