Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31405: fix embed image link removal #153

Merged
merged 1 commit into from Jun 3, 2020
Merged

EZP-31405: fix embed image link removal #153

merged 1 commit into from Jun 3, 2020

Conversation

dew326
Copy link
Member

@dew326 dew326 commented Jun 2, 2020 •
edited

Question Answer
JIRA issue EZP-31405
Bug/Improvement yes
New feature no
Target version 2.0
BC breaks no
Tests pass yes
Doc needed no

This is merge up to 3.0 from the ezsystems/ezplatform-admin-ui#1255

TODO:

  • Implement feature / fix a bug.
  • Ask for Code Review.

@dew326 dew326 added the Bug Something isn't working label Jun 2, 2020
@mnocon
Copy link
Member

mnocon commented Jun 3, 2020 •
edited

@dew326 if it's a merge up to 3.0 shoudn't the base branch here be 2.0?

@dew326 dew326 changed the base branch from master to 2.0 June 3, 2020 07:23
@dew326
Copy link
Member Author

dew326 commented Jun 3, 2020

@mnocon good catch, thanks.

@lserwatka lserwatka merged commit 9014ca0 into 2.0 Jun 3, 2020
@lserwatka lserwatka deleted the fix-embed branch June 3, 2020 10:47
@lserwatka
Copy link
Member

Could you merge it up?

@dew326
Copy link
Member Author

dew326 commented Jun 3, 2020

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@bogusez bogusez bogusez approved these changes

@lucasOsti lucasOsti Awaiting requested review from lucasOsti

Assignees
No one assigned
Labels
Bug Something isn't working QA approved
Milestone
No milestone
5 participants
@dew326 @mnocon @lserwatka @GrabowskiM @bogusez