Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-32351: Custom tags' switch between attributes and content is missing an icon #176

Merged
merged 1 commit into from
Feb 22, 2021
Merged

EZP-32351: Custom tags' switch between attributes and content is missing an icon #176

merged 1 commit into from
Feb 22, 2021

Conversation

konradoboza
Copy link
Member

Question Answer
JIRA issue EZP-32351
Bug/Improvement yes
New feature no
Target version 2.2, master
BC breaks no
Tests pass yes
Doc needed no

In custom tags, there are no icons for switch between attributes and content.

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@konradoboza konradoboza added Bug Something isn't working Ready for review labels Feb 18, 2021
@konradoboza konradoboza self-assigned this Feb 18, 2021
@konradoboza konradoboza removed their assignment Feb 19, 2021
@konradoboza
Copy link
Member Author

Failing tests don't seem to be related.

@bogusez bogusez self-assigned this Feb 19, 2021
@lserwatka lserwatka merged commit 0cbd965 into 2.2 Feb 22, 2021
@lserwatka lserwatka deleted the ezp-32351-custom-tag-switch-no-icons branch February 22, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lserwatka lserwatka lserwatka approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@dew326 dew326 dew326 approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@bogusez bogusez bogusez approved these changes

Assignees

@bogusez bogusez

Labels
Bug Something isn't working QA approved
Milestone
No milestone
7 participants
@konradoboza @lserwatka @Steveb-p @GrabowskiM @dew326 @lucasOsti @bogusez