Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-284: Fixed line breaks inside links #188

Merged
merged 1 commit into from
Jun 15, 2021
Merged

IBX-284: Fixed line breaks inside links #188

merged 1 commit into from
Jun 15, 2021

Conversation

konradoboza
Copy link
Member

@konradoboza konradoboza commented Jun 1, 2021 •
edited
Loading

Question Answer
JIRA issue IBX-284
Bug/Improvement yes
New feature no
Target version 1.1, 2.3, master
BC breaks no
Tests pass yes
Doc needed no

Soft line breaks are not properly interpreted when inserted in links. This PR aims to add proper usage of breakline template, as in other cases.

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@konradoboza konradoboza added Bug Something isn't working Ready for review labels Jun 1, 2021
@konradoboza konradoboza self-assigned this Jun 1, 2021
@konradoboza konradoboza removed their assignment Jun 14, 2021
@bogusez bogusez self-assigned this Jun 14, 2021
@lserwatka lserwatka merged commit 1015a6a into 1.1 Jun 15, 2021
@lserwatka lserwatka deleted the ibx-284-links-missing-soft-breaks branch June 15, 2021 10:29
@lserwatka
Copy link
Member

You can merge it up now.

@konradoboza
Copy link
Member Author

Done in:
2.3: 916c901
master: 7379813

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@damianz5 damianz5 damianz5 approved these changes

@alongosz alongosz alongosz approved these changes

@ciastektk ciastektk ciastektk approved these changes

@bogusez bogusez bogusez approved these changes

Assignees

@bogusez bogusez

Labels
Bug Something isn't working QA approved
Milestone
No milestone
7 participants
@konradoboza @lserwatka @adamwojs @damianz5 @alongosz @ciastektk @bogusez