Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-759: Fixed wrong class taken to calculate toolbar's width #196

Merged
merged 1 commit into from
Jul 15, 2021
Merged

IBX-759: Fixed wrong class taken to calculate toolbar's width #196

merged 1 commit into from
Jul 15, 2021

Conversation

konradoboza
Copy link
Member

@konradoboza konradoboza commented Jul 13, 2021 •
edited
Loading

Question Answer
JIRA issue IBX-759
Bug/Improvement yes
New feature no
Target version 2.3, master
BC breaks no
Tests pass yes
Doc needed no

Currently, there is a wrong class specified when calculating the toolbar's width. That results in JS errors when it changes. Went for .ae-toolbar-styles as it seems to be a generic class shared between all the affected toolbars.

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@konradoboza konradoboza added Bug Something isn't working Ready for review labels Jul 13, 2021
@konradoboza konradoboza self-assigned this Jul 13, 2021
@konradoboza
Copy link
Member Author

Failing tests are unrelated, this case is already known by QA.

@konradoboza konradoboza removed their assignment Jul 13, 2021
@tomaszszopinski
Copy link

@konradoboza Ive come across this bug also on 2.5

@konradoboza
Copy link
Member Author

I will fix it in another PR since the affected code in 2.5 is a part of ezplatform-admin-ui.

@konradoboza konradoboza mentioned this pull request Jul 14, 2021
Merged
2 tasks
@konradoboza
Copy link
Member Author

@tomaszszopinski done: ezsystems/ezplatform-admin-ui#1805.

@piotrbisaga piotrbisaga self-assigned this Jul 14, 2021
piotrbisaga
piotrbisaga approved these changes Jul 15, 2021
View reviewed changes
Copy link

@piotrbisaga piotrbisaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved.
Checked on Ibexa Commerce 3.3.5 with .diff.

@piotrbisaga piotrbisaga removed their assignment Jul 15, 2021
@konradoboza
Copy link
Member Author

@alongosz could you please merge this one?

@lserwatka lserwatka merged commit decfce4 into 2.3 Jul 15, 2021
@lserwatka lserwatka deleted the ibx-759-formatted-breaks-rte-toolbar branch July 15, 2021 08:31
@lserwatka
Copy link
Member

You can merge it up now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@tischsoic tischsoic tischsoic approved these changes

@dew326 dew326 dew326 approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@piotrbisaga piotrbisaga piotrbisaga approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working QA approved
Milestone
No milestone
8 participants
@konradoboza @tomaszszopinski @lserwatka @GrabowskiM @tischsoic @dew326 @lucasOsti @piotrbisaga