Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import RichText from ezpublish-kernel and repository-forms #2

Merged
merged 4 commits into from Mar 28, 2018

Conversation

bdunogier
Copy link
Member

@bdunogier bdunogier commented Mar 23, 2018

EZP-28009

Copies all Rich Text code from ezsystems/ezpublish-kernel and ezsystems/repository-forms.

The first two commits copy files from each package, with a reference to the sha1 the repository was at at this time. The next commit reworks the structure and makes the package work, and the last adds the compiler pass that makes the package compatible with kernel 7.x.

Things that are left

  • Remove deprecated code
  • Think about configuration compatibility (e.g. config that was below ezpublish.fieldtypes.ezrichtext)
  • Consider renaming the package to ezplatform-richtext, as it is not limited to the Field Type

Next tasks

@bdunogier bdunogier changed the title Copied RichText code over from ezpublish-kernel Import RichText from ezpublish-kernel and repository-forms Mar 28, 2018
@bdunogier bdunogier merged commit dff63e4 into ezsystems:master Mar 28, 2018
@Nattfarinn
Copy link
Member

Nattfarinn commented Mar 29, 2018

+43,609 −7

giphy

@bdunogier
Copy link
Member Author

So +36,609 ?
Well it is merged anyway :)

Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hereby approve!

@bdunogier bdunogier deleted the kernel_code branch March 29, 2018 07:44
SerheyDolgushev added a commit to SerheyDolgushev/ezplatform-richtext that referenced this pull request Sep 23, 2020
SerheyDolgushev added a commit to SerheyDolgushev/ezplatform-richtext that referenced this pull request Sep 29, 2020
SerheyDolgushev added a commit to SerheyDolgushev/ezplatform-richtext that referenced this pull request Sep 30, 2020
SerheyDolgushev added a commit to SerheyDolgushev/ezplatform-richtext that referenced this pull request Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants