Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import RichText from ezpublish-kernel and repository-forms #2

Merged
merged 4 commits into from Mar 28, 2018

Conversation

3 participants
@bdunogier
Copy link
Member

commented Mar 23, 2018

EZP-28009

Copies all Rich Text code from ezsystems/ezpublish-kernel and ezsystems/repository-forms.

The first two commits copy files from each package, with a reference to the sha1 the repository was at at this time. The next commit reworks the structure and makes the package work, and the last adds the compiler pass that makes the package compatible with kernel 7.x.

Things that are left

  • Remove deprecated code
  • Think about configuration compatibility (e.g. config that was below ezpublish.fieldtypes.ezrichtext)
  • Consider renaming the package to ezplatform-richtext, as it is not limited to the Field Type

Next tasks

  • Push / link the kernel changes (ezsystems/ezpublish-kernel#2289)
  • Copy files from ezsystems/repository-forms (ezsystems/repository-forms#229)
  • Get it to work with "8.0" kernel (kernel without richtext code)
  • Decide and apply the structure (ping @alongosz)
  • Get unit tests running
  • Get API tests running
  • Get SPI tests running
  • Fix siteaccess aware settings
  • Fix custom tags settings

@bdunogier bdunogier force-pushed the bdunogier:kernel_code branch from 236ceeb to 7c0721f Mar 28, 2018

@bdunogier bdunogier changed the title Copied RichText code over from ezpublish-kernel Import RichText from ezpublish-kernel and repository-forms Mar 28, 2018

@bdunogier bdunogier requested review from alongosz and Nattfarinn Mar 28, 2018

@bdunogier bdunogier force-pushed the bdunogier:kernel_code branch from 7c0721f to edc7e2a Mar 28, 2018

@bdunogier bdunogier merged commit dff63e4 into ezsystems:master Mar 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Nattfarinn

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2018

+43,609 −7

giphy

@bdunogier

This comment has been minimized.

Copy link
Member Author

commented Mar 29, 2018

So +36,609 ?
Well it is merged anyway :)

@alongosz
Copy link
Member

left a comment

I hereby approve!

@bdunogier bdunogier deleted the bdunogier:kernel_code branch Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.