Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-824: Fixed triggering closing link popup on formatted text #204

Merged
merged 2 commits into from
Aug 30, 2021
Merged

IBX-824: Fixed triggering closing link popup on formatted text #204

merged 2 commits into from
Aug 30, 2021

Conversation

konradoboza
Copy link
Member

Question Answer
JIRA issue IBX-824
Bug/Improvement yes
New feature no
Target version 2.3, master
BC breaks no
Tests pass yes
Doc needed no

Followup for ezsystems/ezplatform-admin-ui#1872 targeting v3.

TODO:

  • Implement feature / fix a bug.
  • [ ] Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@konradoboza konradoboza added Bug Something isn't working Ready for review labels Aug 25, 2021
@konradoboza konradoboza requested a review from a team August 25, 2021 07:25
@konradoboza konradoboza self-assigned this Aug 25, 2021
@konradoboza konradoboza requested review from dew326, GrabowskiM, lucasOsti and tischsoic and removed request for a team August 25, 2021 07:46
@konradoboza konradoboza removed their assignment Aug 26, 2021
kacper-wieczorek-ibexa
kacper-wieczorek-ibexa approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved. Tested od 3.3.6 commerce

@lserwatka lserwatka merged commit 66392eb into 2.3 Aug 30, 2021
@lserwatka lserwatka deleted the ibx-824-trigger-link-popup-close-on-formatted-text branch August 30, 2021 09:30
@lserwatka
Copy link
Member

You can merge it up now.

@konradoboza
Copy link
Member Author

Done in 11d8e5f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dew326 dew326 dew326 approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@kacper-wieczorek-ibexa kacper-wieczorek-ibexa kacper-wieczorek-ibexa approved these changes

@GrabowskiM GrabowskiM Awaiting requested review from GrabowskiM

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees
No one assigned
Labels
Bug Something isn't working QA approved
Milestone
No milestone
5 participants
@konradoboza @lserwatka @dew326 @lucasOsti @kacper-wieczorek-ibexa