Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-30626: Change FieldType::getName() arguments #43

Merged
merged 1 commit into from Jun 17, 2019
Merged

EZP-30626: Change FieldType::getName() arguments #43

merged 1 commit into from Jun 17, 2019

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Jun 4, 2019 •
edited by alongosz

Question Answer
JIRA issue EZP-30626
Improvement no
New feature yes
Target version master
BC breaks no
Tests pass yes
Doc needed no

This PR adjust FieldType::getName() arguments to be compatible with eZ\Publish\Core\FieldType\FieldType

Related to: ezsystems/ezpublish-kernel#2661

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@mikadamczyk mikadamczyk self-assigned this Jun 4, 2019
@mikadamczyk mikadamczyk mentioned this pull request Jun 4, 2019
Merged
4 tasks
@barbaragr barbaragr self-assigned this Jun 10, 2019
@alongosz alongosz merged commit b7d5f1d into master Jun 17, 2019
@alongosz alongosz deleted the remove-nameable branch June 17, 2019 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@alongosz alongosz alongosz approved these changes

@barbaragr barbaragr barbaragr approved these changes

@ViniTou ViniTou Awaiting requested review from ViniTou

@pawbuj pawbuj Awaiting requested review from pawbuj

Assignees

@mikadamczyk mikadamczyk

@barbaragr barbaragr

Labels
Ready for QA
Milestone
No milestone
4 participants
@mikadamczyk @adamwojs @alongosz @barbaragr