Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-32108: Added CustomField sort clause #204

Merged
merged 1 commit into from
Dec 10, 2020
Merged

EZP-32108: Added CustomField sort clause #204

merged 1 commit into from
Dec 10, 2020

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Nov 18, 2020

JIRA: EZP-32108

Description

Impl. visitor for ezsystems/ezplatform-kernel#135

Checklist

  • Code follows the code style of this project (use $ composer fix-cs).
  • Change requires a change to the documentation.
  • Code is ready for a review.

@adamwojs adamwojs self-assigned this Nov 18, 2020
@adamwojs adamwojs changed the title EZP-32108: Added RawField sort clause EZP-32108: Added CustomField sort clause Dec 5, 2020
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test to CustomField if possible.

composer.json Outdated
@@ -13,7 +13,7 @@
"require": {
"php": "^7.3",
"ext-json": "*",
"ezsystems/ezplatform-kernel": "^1.3@dev",
"ezsystems/ezplatform-kernel": "dev-ezp_32108",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change intended, or just a temporary thing for tests or something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's temporarily change to enable run updated integration tests suite (including test for Custom Field)

Copy link
Contributor

@ViniTou ViniTou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just either mark in title that we still have tmp commit or just link green build inside PR description.

@alongosz alongosz changed the title EZP-32108: Added CustomField sort clause [REBASE REQUIRED] EZP-32108: Added CustomField sort clause Dec 10, 2020
@adamwojs adamwojs changed the title [REBASE REQUIRED] EZP-32108: Added CustomField sort clause EZP-32108: Added CustomField sort clause Dec 10, 2020
@adamwojs adamwojs merged commit 31cdef7 into master Dec 10, 2020
@adamwojs adamwojs deleted the ezp_32108 branch December 10, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 participants