-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-32108: Added CustomField sort clause #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add test to CustomField
if possible.
composer.json
Outdated
@@ -13,7 +13,7 @@ | |||
"require": { | |||
"php": "^7.3", | |||
"ext-json": "*", | |||
"ezsystems/ezplatform-kernel": "^1.3@dev", | |||
"ezsystems/ezplatform-kernel": "dev-ezp_32108", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change intended, or just a temporary thing for tests or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's temporarily change to enable run updated integration tests suite (including test for Custom Field)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just either mark in title that we still have tmp commit or just link green build inside PR description.
Description
Impl. visitor for ezsystems/ezplatform-kernel#135
Checklist
$ composer fix-cs
).