Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-32111: Added ContentTranslatedName sort clause #205

Merged
merged 4 commits into from
Dec 10, 2020
Merged

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Dec 5, 2020

JIRA: EZP-32111

Description

Impl. visitor for ezsystems/ezplatform-kernel#143

Checklist

  • Code follows the code style of this project (use $ composer fix-cs).
  • Change requires a change to the documentation.
  • Code is ready for a review.
  • Drop 3bc6660 before merge

@adamwojs adamwojs self-assigned this Dec 5, 2020
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add simple test for ContentTranslatedName if possible.

@adamwojs adamwojs changed the title EZP-32111: Added ContentTranslatedName sort clause [REBASE REQUIRED] EZP-32111: Added ContentTranslatedName sort clause Dec 10, 2020

public function visit(SortClause $sortClause): string
{
return 'meta_content__name_s' . $this->getDirection($sortClause);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return 'meta_content__name_s' . $this->getDirection($sortClause);
return 'meta_content_name_s' . $this->getDirection($sortClause);

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamwojs adamwojs changed the title [REBASE REQUIRED] EZP-32111: Added ContentTranslatedName sort clause EZP-32111: Added ContentTranslatedName sort clause Dec 10, 2020
@adamwojs adamwojs merged commit eb1fca2 into master Dec 10, 2020
@adamwojs adamwojs deleted the ezp_32111 branch December 10, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 participants