Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-3553: Moved common search service compiler passes to CoreBundle #240

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

Steveb-p
Copy link
Contributor

@Steveb-p Steveb-p commented Aug 4, 2022

Question Answer
JIRA issue IBX-3553
Type bug
Target Ibexa version v3.3
BC breaks no

Companion PR:

Moves compiler passes from SolrBundle into CoreBundle.

This fixes an issue that might occur if SolrBundle is not enabled, but Elasticsearch bundle is used:

Ibexa\Contracts\Migration\Exception\UnhandledMigrationException {#3839
  #message: "Intentionally not implemented: No mapper available for: Ibexa\Contracts\Core\Search\FieldType\IdentifierField"
  #code: 0
  #file: "./vendor/ibexa/migrations/src/lib/MigrationExecutor.php"
  #line: 71
  -previous: Ibexa\Contracts\Core\Repository\Exceptions\NotImplementedException {#5709
    #message: "Intentionally not implemented: No mapper available for: Ibexa\Contracts\Core\Search\FieldType\IdentifierField"
    #code: 0
    #file: "./vendor/ibexa/core/src/lib/Search/Common/FieldValueMapper/Aggregate.php"
    #line: 90
    trace: {
      ./vendor/ibexa/core/src/lib/Search/Common/FieldValueMapper/Aggregate.php:90 { …}
      ./vendor/ibexa/core/src/lib/Search/Common/FieldValueMapper/Aggregate.php:74 { …}

Where Aggregate class responsible for finding mappers is empty.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@Steveb-p Steveb-p force-pushed the ibx-3553-missing-compiler-pass branch from b8cdf03 to 81c110d Compare August 4, 2022 08:53
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@konradoboza konradoboza requested a review from a team September 5, 2022 07:58
@Steveb-p Steveb-p merged commit 1bdfc7c into 3.3 Sep 9, 2022
@Steveb-p Steveb-p deleted the ibx-3553-missing-compiler-pass branch September 9, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants