IBX-829 [CI] Moved CS and PHPUnit jobs to GitHub Actions #14
Conversation
piotrbisaga
changed the title
.github/workflows/ci.yaml
Outdated
| - '7.3' | ||
| - '7.4' | ||
| composer_options: [ "" ] | ||
| experimental: [false] |
There was a problem hiding this comment.
Unused
| experimental: [false] |
.github/workflows/ci.yaml
Outdated
| - '7.1' | ||
| - '7.3' |
There was a problem hiding this comment.
Out of curiosity, why are we not testing against 7.2?
If were doing it to save time, then it makes sense to not test against 7.3 as well, since using syntax structures not available in it would already be covered by 7.1.
There was a problem hiding this comment.
As I've inherited this and made small changes only I didn't spot it - thanks Paweł.
I've also checked that 7.1 and 7.2 are no longer supported and 7.3 will be out of date pretty soon.
https://www.php.net/supported-versions.php
The question is - should different versions of php be included and 7.1 excluded? Please advise @mnocon @Steveb-p
There was a problem hiding this comment.
While it's true that 7.1 and 7.2 are reaching end of their lifetime, our product declares itself as compatible with those. We can't drop support for them in older versions because it would be a Backward Compatibility break. Removing support for PHP engine is prohibited in semver convention, which we follow.
piotrbisaga
added
the
Ready for a review
|
Kudos, SonarCloud Quality Gate passed!
|
Adjusting CI test to GitHub Actions instead of Travis
TODO: