Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed multiple issues in user_settings/list.html.twig template #35

Merged
merged 1 commit into from
May 14, 2019
Merged

Fixed multiple issues in user_settings/list.html.twig template #35

merged 1 commit into from
May 14, 2019

Conversation

mikadamczyk
Copy link
Contributor

Question Answer
Tickets N/A
Bug fix? no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

This PR cleans template which lists user settings on the site.

Screen Shot 2019-05-13 at 10 37 38 AM

Checklist:

  • Implement tests
  • Coding standards ($ composer fix-cs)

@mikadamczyk mikadamczyk self-assigned this May 13, 2019
@adamwojs adamwojs requested a review from mnocon May 13, 2019 08:39
@adamwojs adamwojs added the Bug Something isn't working label May 13, 2019
@adamwojs adamwojs changed the base branch from master to 1.0 May 13, 2019 10:57
@mikadamczyk mikadamczyk force-pushed the fixed-issues-in-user-settings-list-template branch from c639318 to 24be81f Compare May 13, 2019 11:01
mnocon
mnocon approved these changes May 14, 2019
View reviewed changes
Copy link
Member

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@adamwojs adamwojs merged commit 6fb832a into ezsystems:1.0 May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@pawbuj pawbuj pawbuj approved these changes

@mnocon mnocon mnocon approved these changes

@Nattfarinn Nattfarinn Awaiting requested review from Nattfarinn

@webhdx webhdx Awaiting requested review from webhdx

@ViniTou ViniTou Awaiting requested review from ViniTou

Assignees

@mikadamczyk mikadamczyk

Labels
Bug Something isn't working QA approved Ready for MERGE
Milestone
No milestone
4 participants
@mikadamczyk @adamwojs @pawbuj @mnocon