Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31017: Added Password Validator to change password form #70

Merged
merged 7 commits into from Apr 21, 2020

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Apr 10, 2020

Question Answer
Tickets https://jira.ez.no/browse/EZP-31017
Bug fix? yes
New feature? no
BC breaks? yes (but not sure if it is covered by BC policy - mandatory option for FormType)
Tests pass? yes
Doc needed? no
License GPL-2.0

As a part of removing circular dependencies between ezplatform-user and ezplatform-admin-ui I moved validators in question into this repository.

I have also deprecated passing contentType as part of data class as it should from start be passed as form option and removed deprecated routing aliases.

Additional PRs:

ezsystems/ezplatform-content-forms#24
ezsystems/ezplatform-admin-ui#1348

Checklist:

  • Implement tests
  • Coding standards ($ composer fix-cs)

tests/lib/Validator/Constraint/PasswordTest.php Outdated Show resolved Hide resolved
tests/lib/Validator/Constraint/PasswordTest.php Outdated Show resolved Hide resolved
tests/lib/Validator/Constraint/PasswordTest.php Outdated Show resolved Hide resolved
tests/lib/Validator/Constraint/PasswordValidatorTest.php Outdated Show resolved Hide resolved
tests/lib/Validator/Constraint/PasswordValidatorTest.php Outdated Show resolved Hide resolved
tests/lib/Validator/Constraint/PasswordValidatorTest.php Outdated Show resolved Hide resolved
tests/lib/Validator/Constraint/PasswordValidatorTest.php Outdated Show resolved Hide resolved
tests/lib/Validator/Constraint/PasswordValidatorTest.php Outdated Show resolved Hide resolved
@ViniTou ViniTou force-pushed the ezp-31017-add-validation-errors branch from 6d3f2be to adc3864 Compare April 15, 2020 08:52
@ViniTou ViniTou changed the base branch from master to 2.0 April 17, 2020 07:32
Co-Authored-By: Adam Wójs <adam.wojs@ez.no>
@lserwatka lserwatka merged commit 3857004 into 2.0 Apr 21, 2020
@lserwatka lserwatka deleted the ezp-31017-add-validation-errors branch April 21, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants