Adapt 'platform variable:create' to changed syntax #495
Conversation
andrerom
requested review from
damianz5 and
vidarl
and removed request for
andrerom
|
@vidarl could you review this PR? |
| 4. If you have the need to debug things remotely, set the `SYMFONY_ENV` environment variable to 'dev': | ||
| `platform project:variable:set env:SYMONY_ENV dev`. | ||
| `platform variable:update env:SYMONY_ENV --value 'dev'`. |
There was a problem hiding this comment.
I am a bit fuzzed by the use of update here.. We set the the SYMFONY_ENV in .platform.app.yaml. Have you confirmed that setting this command actually overrides that setting? Honestly, I couldn't find in p.sh docs if environment variables defined in .platform.app.yaml has precedence over project/environment variables or not.
There was a problem hiding this comment.
I have checked it - and it overrides the setting.
Syntax is slightly different though:
platform variable:update --value 'dev' env:SYMFONY_ENV
But simply setting SYMFONY_ENV to dev won't work anyway - in .platform.app.yaml we use composer install :
composer install --no-dev --prefer-dist --no-progress --no-interaction --optimize-autoloader
so dev packages are not installed on p.sh by default
There was a problem hiding this comment.
yes, I know.. We had a comment about this in .platform.app.yaml earlier, but it was removed.
So, maybe add info about this in a 6.5 bullet ?
Syntax in platform CLI according to:
https://docs.platform.sh/tutorials/composer-auth.html#set-the-envcomposerauth-project-variable