Renamed 'ezpublish' to 'app' #70

bdunogier · 2015-11-29T18:44:46Z

Implements http://jira.ez.no/browse/EZP-25110

Renames the ezpublish folder to app, to be closer from symfony standards and documentation.

Also renames:

EzPublishKernel to AppKernel
web/index.php to web/app.php

TODO

Update INSTALL.md
Update nginx and apache2 config
Update Kernel commands: Rename application folder from 'ezpublish' to 'app' ezpublish-kernel#1520

masev · 2015-11-29T19:38:50Z

👍

andrerom · 2015-11-30T09:18:05Z

web/app.php

@@ -50,7 +50,7 @@
    if (($httpCacheClass = getenv('HTTP_CACHE_CLASS')) !== false) {
        $kernel = new $httpCacheClass($kernel);
    } else {
-        require_once __DIR__ . '/../ezpublish/EzPublishCache.php';
+        require_once __DIR__ . '/../app/AppCache.php';
        $kernel = new EzPublishCache($kernel);


emodric · 2015-11-30T15:15:12Z

app/sessions folder is not used by default, is it? Why have it in install instructions and repo?

andrerom · 2015-11-30T15:43:27Z

app/sessions folder is not used by default, is it? Why have it in install instructions and repo?

good question, what is the default now actually? #lazyWeb

emodric · 2015-11-30T15:48:58Z

good question, what is the default now actually? #lazyWeb

On my system its /var/lib/php5/sessions

andrerom · 2015-11-30T16:22:21Z

Passes, ready for review @bdunogier @lolautruche @blankse @masev @emodric @michalpipa

bdunogier · 2015-11-30T16:24:05Z

.gitignore

-/ezpublish/sessions
-/ezpublish/bootstrap.php.cache
+/app/config/parameters.yml
+/app/config/ezplatform_prod.yml


Do we want to keep those here ? We do version them.

Should be removed, yes.

Which files are supposed to be edited by user now? That is my problem here. Is it ok if we generate these during install maybe so they are safly editable by downstream? (Where did we recently discuss this btw?)

IMO, only app/config/parameters.yml is generated on install and it should be ignored and outside of repo. app/config/ezplatform_prod.yml & app/config/ezplatform_dev.yml should be in the repo since they will be versioned almost (if not) always.

emodric · 2015-11-30T18:03:25Z

@andrerom No thoughs about app/sessions folder?

andrerom · 2015-11-30T19:46:02Z

@andrerom No thoughs about app/sessions folder?

I didn't really want to dig into that as part of this, but here goes: it was introduced in ezsystems/ezpublish-community#133 ( https://jira.ez.no/browse/EZP-22747 ), but I see I removed config for it, potentially by mistake in 0cd0fc3. But ok, since we aim to really sync up with Symfony here (within what we have here now), it is now gone.

emodric · 2015-11-30T19:53:22Z

But ok, since we aim to really sync up with Symfony here (within what we have here now), it is now gone.

+1 :)

bdunogier · 2015-11-30T20:27:13Z

but I see I removed config for it, potentially by mistake in 0cd0fc3

Serendipity strikes again.

+1

tharkun · 2015-12-01T09:05:23Z

+1

michalpipa · 2015-12-01T09:22:49Z

+1

bdunogier · 2015-12-01T10:28:30Z

That is plenty of +1, i'll merge this today.

Also renames: - EzPublishKernel to AppKernel - web/index.php to web/app.php

Some cherry picks from #35 that benefits the release, skipping the attempts to simplify this step for now, but at least get it up to date.

Renamed 'ezpublish' to 'app'

Fixed nginx config, broken by PR #70 ( Renamed 'ezpublish' to 'app' )

EZP-25100: Fix class name in AppKernel.php after #70

EZEE-1812: eZPlatform EE v2 improvements

andrerom reviewed Nov 30, 2015
View reviewed changes

andrerom mentioned this pull request Nov 30, 2015

Use SYMFONY_ENV for consistency #42

Closed

andrerom mentioned this pull request Nov 30, 2015

Rename application folder from 'ezpublish' to 'app' ezsystems/ezpublish-kernel#1520

Merged

bdunogier reviewed Nov 30, 2015
View reviewed changes

andrerom mentioned this pull request Dec 1, 2015

Adjust for renamed app folder, but keep support for ezp 5.x ezsystems/ezpublish-docker#47

Merged

emodric mentioned this pull request Dec 1, 2015

EZP-25110: Rename ezpublish folder name to app ezsystems/ezpublish-legacy#1223

Merged

Bertrand Dunogier and others added 11 commits December 1, 2015 16:15

Renamed 'ezpublish' to 'app'

317cd8c

Also renames: - EzPublishKernel to AppKernel - web/index.php to web/app.php

Rename EzPublishCache to AppCache

9c16484

More renaming from ezpublish

ab71711

Rename ENVIRONMENT variable to standard SYMFONY_ENV

163ed04

Rename USE_DEBUGGING variable to standard SYMFONY_DEBUG

f1ba428

Update directory permission Install instructions

83b5a71

Some cherry picks from #35 that benefits the release, skipping the attempts to simplify this step for now, but at least get it up to date.

Further cleanup in vhost config & regrding AppCache

abedf86

[Doc] Update vhost config for index.php to app.php rename

40053d6

Remove gitignore rules for ezplatform_*.yml

2b366d5

Remove use of app/sessions folder that has been unused since 0cd0fc3

8ec977d

Prefix remaining vhost env variables with SYMFONY_

7b3e076

bdunogier force-pushed the rename_app branch from ce265a0 to 7b3e076 Compare December 1, 2015 15:15

bdunogier added a commit that referenced this pull request Dec 1, 2015

Merge pull request #70 from ezsystems/rename_app

c3a6827

Renamed 'ezpublish' to 'app'

bdunogier merged commit c3a6827 into master Dec 1, 2015

bdunogier deleted the rename_app branch December 1, 2015 15:16

bdunogier added a commit that referenced this pull request Dec 2, 2015

Merge pull request #71 from vidarl/fix_broken_nginx_conf

fd1cda0

Fixed nginx config, broken by PR #70 ( Renamed 'ezpublish' to 'app' )

andrerom added a commit that referenced this pull request Dec 2, 2015

Merge pull request #72 from emodric/patch-1

af5bcc9

EZP-25100: Fix class name in AppKernel.php after #70

andrerom mentioned this pull request Mar 29, 2016

EZP-23445: Take SYMFONY_ENV into account in asset dump composer scripts ezsystems/ezpublish-kernel#1627

Merged

andrerom pushed a commit that referenced this pull request Jan 19, 2018

EZEE-1812: eZPlatform EE v2 improvements (#70)

5764dfe

EZEE-1812: eZPlatform EE v2 improvements

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Renamed 'ezpublish' to 'app' #70

Renamed 'ezpublish' to 'app' #70

bdunogier commented Nov 29, 2015

masev commented Nov 29, 2015

andrerom Nov 30, 2015

emodric commented Nov 30, 2015

andrerom commented Nov 30, 2015

emodric commented Nov 30, 2015

andrerom commented Nov 30, 2015

bdunogier Nov 30, 2015

emodric Nov 30, 2015

andrerom Nov 30, 2015

emodric Nov 30, 2015

andrerom Nov 30, 2015

emodric commented Nov 30, 2015

andrerom commented Nov 30, 2015

emodric commented Nov 30, 2015

bdunogier commented Nov 30, 2015

tharkun commented Dec 1, 2015

michalpipa commented Dec 1, 2015

bdunogier commented Dec 1, 2015

Renamed 'ezpublish' to 'app' #70

Renamed 'ezpublish' to 'app' #70

Conversation

bdunogier commented Nov 29, 2015

TODO

masev commented Nov 29, 2015

andrerom Nov 30, 2015

Choose a reason for hiding this comment

emodric commented Nov 30, 2015

andrerom commented Nov 30, 2015

emodric commented Nov 30, 2015

andrerom commented Nov 30, 2015

bdunogier Nov 30, 2015

Choose a reason for hiding this comment

emodric Nov 30, 2015

Choose a reason for hiding this comment

andrerom Nov 30, 2015

Choose a reason for hiding this comment

emodric Nov 30, 2015

Choose a reason for hiding this comment

andrerom Nov 30, 2015

Choose a reason for hiding this comment

emodric commented Nov 30, 2015

andrerom commented Nov 30, 2015

emodric commented Nov 30, 2015

bdunogier commented Nov 30, 2015

tharkun commented Dec 1, 2015

michalpipa commented Dec 1, 2015

bdunogier commented Dec 1, 2015