This repository has been archived by the owner on Apr 4, 2019. It is now read-only.
Use global namespaces in EzPublishKernel #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You beat me to it again :D Thank you very much for picking up and completing this work! Cheers, |
|
+1 from my side |
|
(On a side note, is there an issue for the failing travis/bdd test? |
|
It has nothing to do with this PR, it is related to BDD made by @clash82*, it might not be compatible with how 5.x like setup with legacy stack renders images??? Maybe @bdunogier knows. |
|
+1 |
|
Waiting for feedback from @bdunogier before merging this one. |
|
Hmmm, the test should work independently of the version. Maybe the images are just broken in the install ? :-) |
lolautruche
added a commit
that referenced
this pull request
May 28, 2015
Use global namespaces in EzPublishKernel
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #172 , which seems no longer updated.