EZP-27993: Support quality override by image alias

[peterkeung]

https://jira.ez.no/browse/EZP-27993

In eZ Publish legacy, we can set a global image quality in image.ini, but cannot override this per alias.
This is the reverse problem as eZ Platform / new stack, where you can set the quality by alias but cannot set a global value (liip/LiipImagineBundle#909).

This way, you can set something like this in image.ini to override the global setting:

[medium]
Quality[]
Quality[]=image/jpeg;80

[emodric]

In PR description you mention Quality[image/jpeg]=80 as format. This is the correct one as far as I can see?

[peterkeung]

Sorry, I've fixed the PR description now! Good catch. I got distracted by the format of the internal map.

[emodric]

Maybe do a basic check if $elements[0] and $elements[1] exist before using them?

[peterkeung]

I was copying readMIMETypeQualitySettingFromINI() on line 559, so it's consistent to expect the user to follow the right format. Could harden this in a follow-up PR though.

[emodric]

Useful feature 👍

I'm wondering about why use the override values which are constantly reset and filled for every image conversion process? I guess there's no other way if we want to keep eZImageManager interface intact?

[peterkeung]

Right, this was what I came up with without having to send the alias information to each individual conversion handler. I can certainly change it if someone thinks of a way to do this per alias while maintaining the split in concerns between eZImageManager and the conversion handlers.

[peterkeung]

Ping @alexgorski

[alexgorski]

Very useful feature requested by amnh-digital.

[thiagocamposviana]

Looks good to me
Basically before we could only set the quality by mimetype, now it is possible to define quality by alias, which is very important, also defining quality only by mimtype is so limited it is not very helpful.

[ernestob]

Besides the comment from @emodric about testing the values of the quality array, this looks good.

This is a must have feature. 👍

[benkmugo]

Great addition for sites that have a lot of aliases where quality needs to be controlled better due to alias size differences e.g. huge banners with high-quality needs vs. thumbnails that can be lower quality.

We've got at least a handful of clients where this update would mean a big improvement.

+1 from me

[andrerom]

@crevillo you are also good with this?

[crevillo]

yes! I am, sorry, i didn't see this notification. @peterkeung just pinged me about.

[andrerom]

Thanks @crevillo and @emodric for the reviews, and thanks for the work here @peterkeung!