Update search index in hide cronjob #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
reviewed
Feb 6, 2018
| @@ -49,6 +49,9 @@ | |||
| { | |||
| $cli->output( 'Hiding node: "' . $node->attribute( 'name' ) . '" (' . $node->attribute( 'node_id' ) . ')' ); | |||
| eZContentObjectTreeNode::hideSubTree( $node ); | |||
|
|
|||
| //call appropriate method from search engine | |||
There was a problem hiding this comment.
nitpick: // Call appropriate ..
emodric
approved these changes
Feb 6, 2018
|
Seems legit. I wonder if there are other cases in the legacy kernel where we miss similar calls... eg: content/copy.php first creates a copy and only after it updates the visibility => if copy an hidden node, does the copy gets indexed as visible or invisible ? |
kmadejski
approved these changes
Apr 6, 2018
|
@l0rdJ Seems some new commits have been introduced here now, possible to cleanup tp focus on the |
|
@andrerom I pointed source branch for this PR. |
|
@l0rdJ Ok, but this PR is good to go now right? |
|
Yep, it safe to merge it to master as it is |
andrerom
reviewed
Jun 4, 2018
| @@ -90,6 +90,7 @@ eZOEPopupUtils.settings.onInitDoneArray.push( function( editorElement ) | |||
| ezoeLinkAttribute.timeOut = setTimeout( eZOEPopupUtils.BIND( ezoeLinkAttribute.ajaxCheck, this, url[0] + '_' + id, lid ), 320 ); | |||
| return true; | |||
| }); | |||
| inp.keyup(); | |||
andrerom
pushed a commit
that referenced
this pull request
Jun 29, 2018
* Update search index in hide cronjob (cherry picked from commit 6f4e99f)
mateuszbieniek
pushed a commit
to mateuszbieniek/ezpublish-legacy
that referenced
this pull request
Jan 3, 2019
* Fix link source change (object => node) when editing a version * Update search index in hide cronjob
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.ez.no/browse/EZP-27299