Impossible to use embed when there are duplicate AvailableViewModes

[SerheyDolgushev]

1. Install https://github.com/ezsystems/ezpublish-legacy
2. settings/override/content.ini.append.php:

...
[embed]
AvailableViewModes[]
AvailableViewModes[]=embed
AvailableViewModes[]=embed-inline
AvailableViewModes[]=full
AvailableViewModes[]=line
AvailableViewModes[]=embed
AvailableViewModes[]=custom

3. Edit any object in admin: try to add embed with custom view (or any other view).
4. Disable editor and check content of embed object:

<embed view="5" size="medium" custom:offset="0" custom:limit="5" href="ezobject://59" />

Expected result:

<embed view="custom" size="medium" custom:offset="0" custom:limit="5" href="ezobject://59" />

https://jira.ez.no/browse/EZEE-2042

[SerheyDolgushev]

@glye can you please have a look at this PR and suggest further actions?

[glye]

The simple fix is to not have duplicate AvailableViewModes 😉

Help my tired brain: Why does the duplicate setting change the view to a number?

[SerheyDolgushev]

Sorry, not sure about that now. And I don't think it worth spending time on finding the answer to that question. I guess it is related to the way how the arrays from ini settings are merged.

Closing this PR.