Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPDocs for eZPersistentObject #138

Merged
merged 51 commits into from Nov 24, 2011
Merged

PHPDocs for eZPersistentObject #138

merged 51 commits into from Nov 24, 2011

Commits on Oct 19, 2011

  1. Converted class head to PHPDoc and adjusted description

    @jeromegamez
    jeromegamez committed Oct 19, 2011
    Copy the full SHA
    e20f4f1 View commit details
    Browse the repository at this point in the history

  2. Converted the constructor PHP5 style + PHPDoc

    @jeromegamez
    jeromegamez committed Oct 19, 2011
    Copy the full SHA
    50a19a9 View commit details
    Browse the repository at this point in the history

  3. Added abstract method fetch() 

    eZPersistentObject calls $this->fetch() in the constructor, so this function has to exist in all inherited classes. Perfect case for an abstract.

I also thought about adding an interface, but I think that would be too much at this point.
    @jeromegamez
    jeromegamez committed Oct 19, 2011
    Copy the full SHA
    a360911 View commit details
    Browse the repository at this point in the history

  4. Refactored protected method fill() 

    Declared the method as protected because it is used only by eZPersistentObject::__construct().

Added return values

Added error logging when required information is missing.

Extracted function call from foreach statement into own line.
    @jeromegamez
    jeromegamez committed Oct 19, 2011
    Copy the full SHA
    4ca360b View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2011

  1. Reverted PHP5 changes after discussion with @lolautruche

    @jeromegamez
    jeromegamez committed Oct 20, 2011
    Copy the full SHA
    6644bed View commit details
    Browse the repository at this point in the history

  2. Reverted most code changes in method fill()

    @jeromegamez
    jeromegamez committed Oct 20, 2011
    Copy the full SHA
    af95144 View commit details
    Browse the repository at this point in the history

  3. Reverted code style changes

    @jeromegamez
    jeromegamez committed Oct 20, 2011
    Copy the full SHA
    37509c7 View commit details
    Browse the repository at this point in the history

  4. Added PHPDoc for method replaceFieldsWithShortNames()

    @jeromegamez
    jeromegamez committed Oct 20, 2011
    Copy the full SHA
    d831ca9 View commit details
    Browse the repository at this point in the history

  5. Method count(): PHPDocs, make sure the result is an int

    @jeromegamez
    jeromegamez committed Oct 20, 2011
    Copy the full SHA
    0f6511d View commit details
    Browse the repository at this point in the history

  6. fetch(): PHPDoc

    @jeromegamez
    jeromegamez committed Oct 20, 2011
    Copy the full SHA
    0d8eeeb View commit details
    Browse the repository at this point in the history

  7. remove(): PHPDoc

    @jeromegamez
    jeromegamez committed Oct 20, 2011
    Copy the full SHA
    279d654 View commit details
    Browse the repository at this point in the history

  8. Removed empty PHP comment

    @jeromegamez
    jeromegamez committed Oct 20, 2011
    Copy the full SHA
    e949b42 View commit details
    Browse the repository at this point in the history

  9. removeObject(): PHPDoc

    @jeromegamez
    jeromegamez committed Oct 20, 2011
    Copy the full SHA
    9676c30 View commit details
    Browse the repository at this point in the history

  10. store(): PHPDoc

    @jeromegamez
    jeromegamez committed Oct 20, 2011
    Copy the full SHA
    e7b793a View commit details
    Browse the repository at this point in the history

  11. sync(): PHPDoc

    @jeromegamez
    jeromegamez committed Oct 20, 2011
    Copy the full SHA
    99453ea View commit details
    Browse the repository at this point in the history

  12. storeObject(): PHPDoc

    @jeromegamez
    jeromegamez committed Oct 20, 2011
    Copy the full SHA
    0e6795f View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2011

  1. conditionText(): PHPDoc

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    134df5d View commit details
    Browse the repository at this point in the history

  2. Extended possible parameter values

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    6f3da06 View commit details
    Browse the repository at this point in the history

  3. conditionText(): forgot static

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    0ab6f5b View commit details
    Browse the repository at this point in the history

  4. conditionTextByRow(): PHPDoc

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    14be61d View commit details
    Browse the repository at this point in the history

  5. fetchObjectList(): PHPDoc

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    ae91474 View commit details
    Browse the repository at this point in the history

  6. fetchObjectList(): forgot static AGAIN!

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    6f49320 View commit details
    Browse the repository at this point in the history

  7. handleRows(): PHPDoc

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    3c4304a View commit details
    Browse the repository at this point in the history

  8. swapRow(): PHPDoc

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    dcd5c05 View commit details
    Browse the repository at this point in the history

  9. newObjectOrder(): PHPDoc, make sure the return is an int

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    c837b86 View commit details
    Browse the repository at this point in the history

  10. reorderObject(): PHPDoc

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    3ac5666 View commit details
    Browse the repository at this point in the history

  11. definition(): PHPDoc

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    d588a62 View commit details
    Browse the repository at this point in the history

  12. escapeArray(): PHPDoc

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    3f7df93 View commit details
    Browse the repository at this point in the history

  13. updateObjectList(): basic PHPDoc, added missing 'public's

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    1606059 View commit details
    Browse the repository at this point in the history

  14. attributes(): PHPDoc

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    9e0c204 View commit details
    Browse the repository at this point in the history

  15. hasAttribute(): PHPDoc

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    8c38a13 View commit details
    Browse the repository at this point in the history

  16. attribute(): PHPDoc

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    2b35ded View commit details
    Browse the repository at this point in the history

  17. setAttribute(): PHPDoc

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    d081b0a View commit details
    Browse the repository at this point in the history

  18. hasDirtyData(): PHPDoc

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    43719a8 View commit details
    Browse the repository at this point in the history

  19. setHasDirtyData(): PHPDoc

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    8fc8ba8 View commit details
    Browse the repository at this point in the history

  20. getShortAttributeName(): PHPDoc

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    7bc861a View commit details
    Browse the repository at this point in the history

  21. $PersistentDataDirty: Moved var to the top, PHPDoc

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    372bf5a View commit details
    Browse the repository at this point in the history

  22. Removed abstract definition of class

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    b621ed0 View commit details
    Browse the repository at this point in the history

  23. fetchObjectList() can also return an array of eZPersistentObjects

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    ea37590 View commit details
    Browse the repository at this point in the history

  24. Better explanations for $def

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    324b355 View commit details
    Browse the repository at this point in the history

  25. handleRows() can also return an array of eZPersistenObjects

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    926da05 View commit details
    Browse the repository at this point in the history

  26. Fixed integer casting

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    4a68f16 View commit details
    Browse the repository at this point in the history

  27. Added 'public' declaration in code example

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    cf918fd View commit details
    Browse the repository at this point in the history

  28. Added reference to eZPersistentObject::definition()

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    f104d13 View commit details
    Browse the repository at this point in the history

  29. newObjectOrder(): Removed unused variable

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    449b2c4 View commit details
    Browse the repository at this point in the history

  30. updateObjectList(): Removed unused variables

    @jeromegamez
    jeromegamez committed Oct 21, 2011
    Copy the full SHA
    2a5f393 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2011

  1. Changed @access private to @access protected 

    Also added @todo to change the "real" access someday and removed a needless @static PHPDoc
    @jeromegamez
    jeromegamez committed Oct 24, 2011
    Copy the full SHA
    1626eb2 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2011

  1. Added check for $def["grouping"]... 

    … as done in #215
    @jeromegamez
    jeromegamez committed Nov 22, 2011
    Copy the full SHA
    36d1179 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2011

  1. Reverted code changes

    @jeromegamez
    jeromegamez committed Nov 24, 2011
    Copy the full SHA
    22a6e96 View commit details
    Browse the repository at this point in the history

  2. Reverted code changes

    @jeromegamez
    jeromegamez committed Nov 24, 2011
    Copy the full SHA
    fb352c2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'ezpersistentobject' of github.com:jeromegamez/ezpublish… 

    … into ezpersistentobject
    @jeromegamez
    jeromegamez committed Nov 24, 2011
    Copy the full SHA
    d801d5a View commit details
    Browse the repository at this point in the history