[PHP] Fix some PHP 7.2 deprecations #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
commented
Aug 13, 2018
| @@ -1197,7 +1197,7 @@ static function processElementTransformationList( $tpl, &$node, $elements, &$pri | |||
| static function processElementTransformationChild( $useComments, $php, $tpl, &$node, | |||
| $elementTree, $elementList, &$resourceData ) | |||
| { | |||
| $count = count( $elementList ); | |||
| $count = $elementList instanceof Countable || is_array( $elementList ) ? count( $elementList ) : 0; | |||
There was a problem hiding this comment.
According to doc count() returns 1 on non countable / arrays, but 0 on null. As variable is used as array beneath this is assuming 0 if not countable / array.
There was a problem hiding this comment.
Can we use https://github.com/symfony/polyfill-php73 and its is_countable method for this?
emodric
reviewed
Aug 13, 2018
| @@ -1197,7 +1197,7 @@ static function processElementTransformationList( $tpl, &$node, $elements, &$pri | |||
| static function processElementTransformationChild( $useComments, $php, $tpl, &$node, | |||
| $elementTree, $elementList, &$resourceData ) | |||
| { | |||
| $count = count( $elementList ); | |||
| $count = $elementList instanceof Countable || is_array( $elementList ) ? count( $elementList ) : 0; | |||
There was a problem hiding this comment.
Can we use https://github.com/symfony/polyfill-php73 and its is_countable method for this?
| { | ||
| return -1; | ||
| } | ||
| else if ( $a == $b ) |
emodric
approved these changes
Aug 13, 2018
glye
approved these changes
Aug 13, 2018
lib/ezutils/classes/ezphpcreator.php
Outdated
| @@ -565,7 +565,7 @@ function thisVariableText( $value, $column = 0, $iteration = 0, $maxIterations = | |||
| $column += strlen( $text ); | |||
| $valueKeys = array_keys( $value ); | |||
| $isIndexed = true; | |||
| for ( $i = 0; $i < count( $valueKeys ); ++$i ) | |||
| for ($i = 0, $count = count($valueKeys); $i < $count; ++$i ) | |||
There was a problem hiding this comment.
FWIW, unbalanced use of space-inside-parentheses.
lib/ezutils/classes/ezphpcreator.php
Outdated
| @@ -676,7 +676,7 @@ static function variableText( $value, $column = 0, $iteration = 0, $maxIteration | |||
| $column += strlen( $text ); | |||
| $valueKeys = array_keys( $value ); | |||
| $isIndexed = true; | |||
| for ( $i = 0; $i < count( $valueKeys ); ++$i ) | |||
| for ($i = 0, $count = count($valueKeys); $i < $count; ++$i ) | |||
There was a problem hiding this comment.
Unbalanced use of space-inside-parentheses.
andrerom
force-pushed
the
php_deprecations
branch
from
0b94221
to
34bb333
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo: