Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-29723: Content object attributes not set properly #1412

Closed
wants to merge 1 commit into from
Closed

EZP-29723: Content object attributes not set properly #1412

wants to merge 1 commit into from

Conversation

pbek
Copy link
Contributor

@pbek pbek commented Jan 3, 2019

This pull request solves https://jira.ez.no/browse/EZP-29723 while still fixing https://jira.ez.no/browse/EZP-23088.

@glye glye requested a review from alongosz January 3, 2019 12:45
@glye
Copy link
Member

glye commented Jan 3, 2019

Would also prefer commit title like: EZP-29723: Content object attributes not set properly
But we can do that on merge.

@andrerom andrerom changed the title fixed EZP-29723 EZP-29723: Content object attributes not set properly Jan 7, 2019
@giRobert
Copy link

Hey there, when will this be merged into master?

@glye glye requested a review from andrerom January 10, 2019 09:52
andrerom
andrerom approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor

@andrerom andrerom left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, but this should be backported and thus should be targeting 2017.12 branch.

@pbek are you up for that or do you need some guidance on it?

@pbek
Copy link
Contributor Author

pbek commented Jan 10, 2019

@andrerom are you asking me to do a pull request to https://github.com/ezsystems/ezpublish-legacy/tree/2017.12? I would manage.

@pbek pbek mentioned this pull request Jan 10, 2019
Merged
@pbek
Copy link
Contributor Author

pbek commented Jan 10, 2019 •
edited

here you are: #1416

@andrerom andrerom closed this Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glye glye glye approved these changes

@andrerom andrerom andrerom approved these changes

@alongosz alongosz Awaiting requested review from alongosz

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@pbek @glye @giRobert @andrerom