Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-29723: Content object attributes not set properly #1412

Closed
wants to merge 1 commit into
base: master
from

Conversation

4 participants
@pbek
Copy link
Contributor

pbek commented Jan 3, 2019

This pull request solves https://jira.ez.no/browse/EZP-29723 while still fixing https://jira.ez.no/browse/EZP-23088.

@glye glye requested a review from alongosz Jan 3, 2019

@glye

This comment has been minimized.

Copy link
Member

glye commented Jan 3, 2019

Would also prefer commit title like: EZP-29723: Content object attributes not set properly
But we can do that on merge.

@andrerom andrerom changed the title fixed EZP-29723 EZP-29723: Content object attributes not set properly Jan 7, 2019

@giRobert

This comment has been minimized.

Copy link

giRobert commented Jan 10, 2019

Hey there, when will this be merged into master?

@glye

glye approved these changes Jan 10, 2019

@glye glye requested a review from andrerom Jan 10, 2019

@andrerom
Copy link
Member

andrerom left a comment

+1, but this should be backported and thus should be targeting 2017.12 branch.

@pbek are you up for that or do you need some guidance on it?

@pbek

This comment has been minimized.

Copy link
Contributor Author

pbek commented Jan 10, 2019

@andrerom are you asking me to do a pull request to https://github.com/ezsystems/ezpublish-legacy/tree/2017.12? I would manage.

@pbek

This comment has been minimized.

Copy link
Contributor Author

pbek commented Jan 10, 2019

here you are: #1416

@andrerom andrerom closed this Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.