EZP-29096: Do not store empty draft values in DB

[pkamps]

The issue and steps to reproduce it are described here:
https://jira.ez.no/browse/EZP-29096

Or use those steps:

• Create a new user account
• Do not fill any values in the form
• Close the browser tab
• Try to create a new user account
• You will get a transaction error

This patch will prevent the user creation to store any draft data into the DB unless the editor specified a user login.

[andrerom]

Nice! 👍

We should aim to place this one 2017.12 and up. As for Travis, unsure why but tests seems to fail with:

.PHP Fatal error:  Call to a member function store() on null in /home/travis/build/ezsystems/ezpublish-legacy/kernel/classes/datatypes/ezuser/ezusertype.php on line 282

[glye]

Agree on 2017.12, and we must figure out why that test breaks.

[glye]

onPublish() fails because there is no user object. Seems the code expects the draft to have been stored, so bigger changes are needed.
https://github.com/ezsystems/ezpublish-legacy/pull/1417/files#diff-7c45a8ca23a28df173a64ef5548180c0R282

[peterkeung]

Are tests passing with the latest commit?

[glye]

@peterkeung No, sorry. Don't you have access to see the results? Travis says eZUserTypeRegression::testUpdatePasswordUpdatesSerializedData The password hash stored in the user attribute should have been updated Failed asserting that null is not equal to null.

[glye]

Tests pass! 🎉 🙌
Some CS issues and minor grumbles, and questions about other changes, in particular the getSerializedPasswordHash change.

[glye]

Suggested change

	$contentObjectAttribute->attribute( 'object_version' )->attribute( 'status' ) == 0
	$contentObjectAttribute->attribute( 'object_version' )->attribute( 'status' ) === 0

Or can this be a string? I would not think so.

[pkamps]

Hope you don't mind if I ignore it. Maybe it's a string and then it would hurt to be extra strict here.

[glye]

We ought to be strict, strictly speaking ;) eZContentObjectVersion says it's an integer. But I see many cases where we aren't strict, so I guess this can pass if others agree.

[andrerom]

@pkamps can you accept / reject @glye's fixes?

[andrerom]

LGTM